Run function refactored

bucharest-gold / szero

The main goal is to show unused dependencies on Node.js modules, more specifically, to show that Foo dependency declared in package.json is not being used because there is no require('foo').

Other

17 stars 6 forks source link

Run function refactored #103

Closed tiagofabre closed 7 years ago

tiagofabre commented 7 years ago

Run function now makes less things.

Also getTextFromRequire is being reutilized to avoid this

This pull request is trying to solve #59

[x] Testes - total: 61 - passing: 61
[x] The output is the same before and after the modifications
[x] ESlint

coveralls commented 7 years ago

Coverage increased (+0.6%) to 90.0% when pulling b1eed1d9f2a762ec908ff87efd7a9efc78923d19 on tiagofabre:refactoring into f03e149f539a897aec1ee4005adb368b08b545c2 on bucharest-gold:master.

helio-frota commented 7 years ago

@tiagofabre it is looking great, but can you please remove the default parameter from function run (directory, options = {}) { since node 4x does not support this.

coveralls commented 7 years ago

Coverage increased (+0.7%) to 90.031% when pulling cdac961a9e23a1717632942373042efec6af870b on tiagofabre:refactoring into f03e149f539a897aec1ee4005adb368b08b545c2 on bucharest-gold:master.

coveralls commented 7 years ago

Coverage increased (+0.7%) to 90.031% when pulling cdac961a9e23a1717632942373042efec6af870b on tiagofabre:refactoring into f03e149f539a897aec1ee4005adb368b08b545c2 on bucharest-gold:master.

helio-frota commented 7 years ago

@tiagofabre thanks !