feat: support use s3 sign v2 by config

buchgr / bazel-remote

A remote cache for Bazel

https://bazel.build

Apache License 2.0

576 stars 150 forks source link

feat: support use s3 sign v2 by config #726

Closed hyphennn closed 5 months ago

hyphennn commented 6 months ago

This PR support to set s3 sign as v2. Resolves #725 Now user could set a new flag --s3.disable_v4_sign=true when there auth_method is secret_key, which will lead using minio/pkg/credentials.NewStaticV2 as the initialization of s3 credential. This can support some situation when s3 do not support v4 sign well.

mostynb commented 5 months ago

Sorry it took me so long to get back to this. I squashed your commits, then made a small change to the values (eg v2 instead of s3v2), and landed these changes on the master branch.