search

buchgr / bazel-remote

A remote cache for Bazel
https://bazel.build
Apache License 2.0
576 stars 150 forks source link

fix infinite recursion with idle timer and http requests #727

Closed jchorl closed 6 months ago

jchorl commented 6 months ago

Noticed that bazel-remote will crash with a wicked stack trace if you enable the idle-timer.

Tested locally. Not really sure how to write a good test for this.

Repro is pretty easy:

root@9b9a2900fc12:/work# ./bazel-remote-without-patch --dir /data --max_size 1 --idle_timeout 1m

Separate terminal:

root@9b9a2900fc12:/work# curl --head --fail http://localhost:8080/cas/e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855
curl: (52) Empty reply from server

Stack trace omitted because it is too large.

With the patch:

root@9b9a2900fc12:/work# ./bazel-remote-with-patch --dir /data --max_size 1 --idle_timeout 1m

Separate terminal:

root@9b9a2900fc12:/work# curl --head --fail http://localhost:8080/cas/e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855
HTTP/1.1 200 OK
Content-Length: 0
Date: Thu, 04 Jan 2024 22:39:56 GMT

We see the log:

2024/01/04 22:39:56 HEAD 200       127.0.0.1 /cas/e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855
mostynb commented 6 months ago

Thanks for the fix- let's see if #728 fails nicely on the tip of main, and if so we can land these together.

mostynb commented 6 months ago

Thanks again- cherry-picked to the tip of the master branch (after the test was added).