allow configuring grpc max receive message size

buchgr / bazel-remote

A remote cache for Bazel

https://bazel.build

Apache License 2.0

576 stars 150 forks source link

allow configuring grpc max receive message size #738

Open jasonwbarnett opened 4 months ago

jasonwbarnett commented 4 months ago

Fixes https://github.com/buchgr/bazel-remote/issues/658

buchgr commented 3 months ago

Seems like Pants is implementing a principled fix in https://github.com/pantsbuild/pants/pull/20708. How do you want to proceeed with this PR @jasonwbarnett ?

jasonwbarnett commented 3 months ago

@buchgr It's up to you. I don't know much about gRPC and when it is or isn't appropriate to increase the default message send/receive sizes. If there are cases where it's appropriate, I'd like to see this get merged. If there aren't ever scenarios where this is appropriate, it should probably just be closed without a merge.

mostynb commented 3 months ago

I think if we decide to land this PR, then the flag needs to have a prominent warning about ensuring that the client side configuration matches for all clients that use the cache.

However, if pants only needs this for FindMissingBlobs, then that should be an easy fix on the pants side and we should not add this option to bazel-remote.