Support LDAP authentication with unauthorized reads

buchgr / bazel-remote

A remote cache for Bazel

https://bazel.build

Apache License 2.0

576 stars 150 forks source link

Support LDAP authentication with unauthorized reads #740

Open JonasScharpf opened 3 months ago

JonasScharpf commented 3 months ago

This PR is based on #101 and resolves #100

It provides unauthorized reads when using LDAP, config via command line args and minimal config file testing for the new LDAP section

This is my first GO thing ever, so it might not be perfect

mostynb commented 3 months ago

so I've fixed your remarks and added a end-to-end fake LDAP server test. But the remaining golangci linter errors are beyond my knowledge to fix them by myself. I have to admit that I simply copied the httpServer thing from an example ...

Sorry it took me longer than expected to get back to this. I should have some time to read through this while I'm travelling later this week.

JonasScharpf commented 2 months ago

Hey @mostynb how are you doing? Might it be possible to find some time for this PR during your next trip? :wink:

JonasScharpf commented 1 month ago

@mostynb I'm sorry to ask again for your time + help with this PR, it's been now in review since almost 2 months