It appears that remote downloader does not pass HTTP headers

[marekkrk]

When working with Bazel OCI rules I can download images from a local Docker registry with remote downloader disabled.

When I enable --experimental_remote_downloader, OCI rules fail to download images and the local Docker registry logs the following error: "OCI manifest found, but accept header does not support OCI manifests"

This indicates that the remote downloader does not support headers passed to repository_ctx.download. Support for settings cutom headers is implemented in Bazel itself: https://github.com/bazelbuild/bazel/issues/17829 https://blog.aspect.build/custom-download-headers

[mostynb]

Hi, I'm not sure how this relates to bazel-remote?

[xuzhenglun]

I submit a simple PR to support this. could u plz @marekkrk test for that ?

https://github.com/buchgr/bazel-remote/pull/760

For me, I'm a user of rules_oci, but rules_oci still not works even though all headers are handled. Since it looks like theAuthorization in ctx.download.auth params still not passthrough to FetchBlob now.

[marekkrk]

Hi, I'm not sure how this relates to bazel-remote?

If you use --experimental_remote_downloader to delegate HTTP downloads from Bazel to Bazel Remote Cache, the cache appears to omit custom HTTP headers that Bazel itself supports since 7.1.0: https://github.com/bazelbuild/bazel/issues/17829

[mostynb]

Merged @xuzhenglun's PR, hopefully that resolves this issue- please let me know if not.

[marekkrk]

Merged @xuzhenglun's PR, hopefully that resolves this issue- please let me know if not.

Thanks, will test by tomorrow.

[arjantop-cai]

@mostynb Is there a release planned that would include this change?