search

buchhalter-ai / buchhalter-ai-cli

The buchhalter open-source command line tool to automate invoice downloads from suppliers. Free, customizable, and designed for seamless financial workflow integration.
https://buchhalter.ai
Other
4 stars 1 forks source link

Browser: Remove not required go routine in `downloadAll` step #25

Closed andygrunwald closed 5 months ago

andygrunwald commented 5 months ago

How I read the source code this go routine is not needed at all.

brgmn commented 5 months ago

@andygrunwald Tested this change with the digitalocean recipe and it leads to an open browser not quitting (after having downloaded all invoices). The idea of the waitgroup is to wait for all downloads to finish. Then close the browser. Please check again.

andygrunwald commented 5 months ago

This is strange. In my setup it runs through and closes the browser. This PR is not changing the waitgroup, but removes the go routine. Can you test again? Or maybe testing even with the current main?

brgmn commented 5 months ago

@andygrunwald UPDATE! Works now! This is a bit strange but I think I had an temporary error, only. Sorry for the confusion.

andygrunwald commented 5 months ago

This was superseeded by https://github.com/buchhalter-ai/buchhalter-ai-cli/pull/33