search

buchizo / ClaudiaIDE

This extension can change easily the background image of editor window in Visual Studio.
https://marketplace.visualstudio.com/items?itemName=kbuchi.ClaudiaIDE
648 stars 113 forks source link

SlideShowImageProvider crash #187

Closed xx790 closed 8 months ago

xx790 commented 8 months ago

I think there a flaw in SlideShowImageProvider. It caused VS crash by itself sometime after I deleted some images from the folder that it uses.

After GetBitmap() gets nonexistent file path - it calls OnSettingChanged(null, null), but that doesn't work as expected.

I'd suggest extracting image paths refresh into a separate method and call that instead of OnSettingChanged.

buchizo commented 8 months ago

I fixed it by v3.1.34

xx790 commented 8 months ago

Thank you. It seems to work fine now.