buchizo / ClaudiaIDE

This extension can change easily the background image of editor window in Visual Studio.
https://marketplace.visualstudio.com/items?itemName=kbuchi.ClaudiaIDE
654 stars 113 forks source link

Failed to apply custom text editor background color #54

Closed AIGRIND-LLC closed 5 years ago

AIGRIND-LLC commented 5 years ago

Hello! After the last update the extension does not display the custom color assigned to the text editor. And the background image has got an incorrect offset.

Here is the correct layout when the extension is disabled.

And here is the wrong layout when the extension is enabled.

There is the extension settings:

And here is the test image just in case.

buchizo commented 5 years ago

That is by design on ver2.2.x.

Details

Ver 2.1.0 is depends on editor adornment layer on text editor part. Text editor part is red dashed line as follows:

image

ClaudiaIDE add image layer on editor adornment layer.

image

result:

image image

An adornment layer is inside some parts (e.g. scrollbar, line number). However adornment layer is view port as virtual area. ClaudiaIDE should be reset position when scrolling. So that is occurred flickering.

Ver 2.2.x is not depends on editor adornment layer. Ver2.2.0 add background image to document of editor window. Editor window is bottom layer than other parts (e.g. scrollbar, line number, adornment layer and text editor). Ver 2.2.x ClaudiaIDE need to transparent from solid color of text background color because ClaudiaIDE's background image set to bottom than text editor.

image

image

result:

image image image image

Ver2.2.x ClaudiaIDE's background image position and text background color are different from ver2.1.0. But, I got no flickering, maybe; And if I choose large background image, I can show image beyond line number area.

buchizo commented 5 years ago

Which do you like better?

I like ver2.2.x style because it's no flickering and expand image to line number area. I don't mind some position offset. It's a trivial issue with big images. However I possibility need to modify image to correct offset in some case.

If you like ver 2.1.0 style, you can use old version from this vsix in zip, and you should set disable automaticaly update in this extensions.

Thanks,

AIGRIND-LLC commented 5 years ago

Thanks for the great explanation.