search

buchizo / ClaudiaIDE

This extension can change easily the background image of editor window in Visual Studio.
https://marketplace.visualstudio.com/items?itemName=kbuchi.ClaudiaIDE
641 stars 112 forks source link

Remove explicit calls to GC.Collect #73

Closed davkean closed 3 years ago

davkean commented 3 years ago

Hey, I'm from the Visual Studio performance team. This extension came up on the radar for introducing UI delays (where VS has become unresponsive) that last over 1 second. These interrupt keyboard and mouse events and make customer's experience with VS a little bit worse with this extension installed.

Here are the numbers just over the past 21 days:

Root Failure Leaf Failure Hits That Delayed Keyboard/Mouse Total Hits Duration (75th Pct) Delayed Mouse Clicks Delayed Key Strokes
claudiaide.dll!ClaudiaIDE.ClaudiaIDE+<b___0>d.MoveNext claudiaide.dll!ClaudiaIDE.ClaudiaIDE+<b___0>d.MoveNext 181 8,074 1.50 sec 114 68

These calls to GC.Collect are unneeded and interrupt .NET and Visual Studio algorithms for managing memory in the VS process.

buchizo commented 3 years ago

@davkean Thank you for your contribution! Initially I was write explicit call it... sorry I forgot reason..