search

buckaroo-it / BuckarooSDK_PHP

Repository containing the PHP SDK by Buckaroo
MIT License
11 stars 7 forks source link

[BP-1996] vlucas/phpdotenv should be dev-dependency #32

Closed ederuiter closed 2 years ago

ederuiter commented 2 years ago

Currently the vlucas/phpdotenv package is a direct dependency although it is only used in the examples/tests.

For us this lead to problems with an old laravel install (as laravel 7 required phpdotenv 4, and this package requires phpdotenv 5)

ShuCh3n commented 2 years ago

You're right! We are going to remove that

Buckaroo-Rens commented 2 years ago

Thanks again @ederuiter added the bug to one of our upcoming sprint. Are you helped with us providing a commit/patch in the meantime or can you wait until our next release?

ederuiter commented 2 years ago

I can wait until the next release as I was able to workaround it by adding this to our composer.json

"provide": {
        "vlucas/phpdotenv": "5.4"
    },
Buckaroo-Rens commented 2 years ago

Thanks @ederuiter, we keep you posted :)

ShuCh3n commented 2 years ago

vlucas/phpdotenv is moved to dev in the next update