buckaroo-it / BuckarooSdk_DotNet

Software Development Kit which can be used for easy access to the Buckaroo API.
MIT License
6 stars 18 forks source link

#2 and #3 #4

Closed coenvdwel closed 6 years ago

coenvdwel commented 6 years ago

Issue #2 I was able to resolve by simply exposing the internal Services property so it can be serialized in the SendRequest method.

For issue #3, however, perhaps some backend evaluation is required. This change would at least expose the desired information to the SDK users, but will make the multiple services call heavier when users omit the version.

buckaroo-it commented 6 years ago

Thank you for reporting this. The ignored parameters are a particular bug that escaped our attention because because the call does not fail apparently. We just failed to check the resultset that was returned. We will also extend our tests so this should not happen again.