buckaroo-it / BuckarooSdk_DotNet

Software Development Kit which can be used for easy access to the Buckaroo API.
MIT License
6 stars 18 forks source link

Differences from NuGet package and this source? #7

Open coenvdwel opened 6 years ago

coenvdwel commented 6 years ago

How come the NuGet package depends on Newtonsoft 10.x.x while this repo shows a dependency on 9.x.x? It is also not targeting .NET Standard 2.0, which the NuGet package does.

This prevents me from loading my own fork in my project, where I am adding support for some payment methods such as Bancontact and AfterPay.

FrostAndFlame commented 6 years ago

@coenvdwel Yeah, this is true - NuGet package is outdated. https://www.nuget.org/packages/BuckarooSDK/ last updated 8 months ago 👎 Your latest fixes aren't included in NuGet package (https://github.com/buckaroo-it/BuckarooSdk_DotNet/pull/6/files) @buckaroo-it @sjaak-buckaroo

coenvdwel commented 6 years ago

(for the record; we've moved to using our own fork to avoid these issues, among others)

FrostAndFlame commented 6 years ago

(for the record; we've moved to using our own fork to avoid these issues, among others)

@coenvdwel Do you have public Nuget package for it ?

coenvdwel commented 6 years ago

(for the record; we've moved to using our own fork to avoid these issues, among others)

@coenvdwel Do you have public Nuget package for it ?

Never bothered, but I've now pushed it! 🎂