search

buckaroo-it / Magento2

Repository containing the Magento2 plugin by Buckaroo
MIT License
28 stars 35 forks source link

BP-3465 Creditcard is grouped config not working correctly #941

Closed bke1999 closed 4 months ago

bke1999 commented 6 months ago

https://github.com/buckaroo-it/Magento2/blob/6a84ec89db1842c894cb1251888d42cafaa13eee/view/frontend/web/js/view/payment/method-renderer/creditcard.js#L172 The script currently checks for strict equality but since the config returns string '1' the result is always false. As a work around we changed comparison to non strict but you may want to change value return from the config. Magento 2.4.6-p4. Module Version 1.47.0

jemico commented 6 months ago

I can confirm that this option is not working correctly.

@bke1999 can you explain me more how i can use your workarround?

Buckaroo-Rens commented 5 months ago

Thanks both @bke1999 and @jemico for notifying us. We will look into this a.s.a.p.

SandervdHulst commented 5 months ago

Thank you @bke1999 and @jemico. This is a known issue and the fix will be added to our next release. We have created a Pull Request for this issue: BP-3465 creditcards are not displayed in grouped.

jemico commented 5 months ago

@SandervdHulst added the fix and it is working! Thanks

Buckaroo-Rene commented 5 months ago

@jemico ,

Good to hear and thank you for confirming this so quickly.

Buckaroo-Rene commented 4 months ago

Issue closed because this has been released in: v1.48.0