search

buckaroo-it / Magento2

Repository containing the Magento2 plugin by Buckaroo
MIT License
28 stars 35 forks source link

BP-3564 Incorrect calculation of Grand Total Excluding Tax in js #978

Open Ahmet-Djedovic opened 3 months ago

Ahmet-Djedovic commented 3 months ago

Issue Overview: The current implementation of the getGrandTotalExclTax function in the module is flawed. view/frontend/web/js/view/checkout/summary/grand-total.js

It calculates the grand total excluding tax using a manual subtraction of the tax amount from the grand total. This method is prone to errors and may not always produce accurate results.

Proposed Solution: Utilize the simplified and more reliable implementation of the getGrandTotalExclTax function from Magento 2 default. This implementation directly returns the grand total from the 'total' object, ensuring accurate calculations without the need for manual adjustments.

Proposed Changes:

Buckaroo-Rene commented 3 months ago

@Ahmet-Djedovic ,

Thank you for logging this issue. We'll take a look at with the team.

Regards, René