buckets / application

Buckets Desktop Application
https://www.budgetwithbuckets.com
187 stars 2 forks source link

Merge button unresponsive on Android #988

Closed iron-condor closed 8 months ago

iron-condor commented 8 months ago

Desktop version: Buckets Beta v0.73.3 Mobile version: Android Buckets v0.3.0

I just set up Relay with the beta version of the desktop application, and with the Android application. I've previously synced to my mobile device from my desktop before, but the last sync was not with the beta version of the desktop app, and dates from before the v0.73.0 change. That piece of information may be relevant to this issue.

After syncing, I opened the budget on my phone and was able to see the new copy from my desktop under "Incoming updates." Tapping the merge button did nothing, however. No obvious progress, or any toasts with an error message.

I suspect this is because of the breaking change made in v0.73.0 that switched numeric IDs to GUIDs. It's possible that the mobile app can't handle a merge between the old schema and the new schema. I wouldn't expect that to become a necessary feature, since the workaround is as simple as deleting the budget on mobile and re-syncing it from desktop.

Still, it may be a good idea to put a location on that app screen for error messages to appear. A toast would also work; though errors that disappear after a few seconds tend to be a faux pas in UX

I've attached a video of the issue happening

https://github.com/buckets/application/assets/38388619/278c7288-ad38-4b20-bd20-e13e2aa5fbec

iffy commented 8 months ago

Yes, I would guess this might be because of the ID -> GUID change. Can you delete the budget on the mobile app and try again? Settings > Menu > Budgets will get you to the place you can delete budgets. Then after you make another change in the desktop app, see if merging works.

The latest mobile version (0.3.1) actually provides feedback when you press the button, because, yes, having no feedback after pressing the button was definitely an oversight :)

iron-condor commented 8 months ago

Yup, that fixed it. Thanks for adding visual feedback!