search

buckets / application

Buckets Desktop Application
https://www.budgetwithbuckets.com
184 stars 2 forks source link

A transaction "transfer" should not go to make it rain #995

Open MagisterEx opened 4 months ago

MagisterEx commented 4 months ago

When a transaction such as a credit card payment comes and is categorized as a transfer, it shows in the make it rain budget. It shouldn't.

iffy commented 4 months ago

Can you provide an example? I'm not able to duplicate this. Categorizing as a transfer shouldn't change the rain amount. Here's an example:

Screen Shot 2024-04-24 at 9 27 35 AM Screen Shot 2024-04-24 at 9 27 59 AM Screen Shot 2024-04-24 at 9 28 09 AM
MagisterEx commented 4 months ago

Good morning,

It is because you have both transactions, the + and -. But let say you have automatic transactions (I use Simplefin) and you just have the CC account transaction (+) for a few day before the transaction from your account (-) comes in.... It shows in Rain

On Wed, Apr 24, 2024 at 6:31 AM Matt Haggard @.***> wrote:

Can you provide an example? I'm not able to duplicate this. Categorizing as a transfer shouldn't change the rain amount. Here's an example: Screen.Shot.2024-04-24.at.9.27.35.AM.png (view on web) https://github.com/buckets/application/assets/161727/72977949-9f56-431a-8f1b-6cd8d5182fd8 Screen.Shot.2024-04-24.at.9.27.59.AM.png (view on web) https://github.com/buckets/application/assets/161727/db2fec65-f39d-43c6-946b-8905473a7b16 Screen.Shot.2024-04-24.at.9.28.09.AM.png (view on web) https://github.com/buckets/application/assets/161727/08d56602-e525-4f29-b8e4-f9dd310bb9e3

— Reply to this email directly, view it on GitHub https://github.com/buckets/application/issues/995#issuecomment-2074955012, or unsubscribe https://github.com/notifications/unsubscribe-auth/A47WSJ5Z22A3QKTKSQ5GIVTY66X47AVCNFSM6AAAAABGWA7MC6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANZUHE2TKMBRGI . You are receiving this because you authored the thread.Message ID: @.***>

iffy commented 4 months ago

Yes, without the corresponding transaction other side of the transaction, it won't reflect reality. Rain is calculated as Accounts total balance - Buckets total balance (with some adjustment for future months). So if you account balances increase or decrease, rain will change by the same amount.

james4141 commented 3 weeks ago

Possible solution, aside from changing the rain calculation to not include Transfers: Allow the user to choose a To/From account when categorizing the imported transaction as a Transfer. This feature already exists when manually entering a transaction. If the other half of the transaction doesn't already exist, create it. Related to #430 - maybe also consider some additional handling for the duplication transaction that either already got imported by SimpleFIN, or will be imported later.