search

buckeye-current-software / Clicky-Board-Battery-Balancer

0 stars 8 forks source link

Pull Clicky Boards #5

Closed cgreenbaum closed 8 years ago

cgreenbaum commented 8 years ago

I think I covered all the bases. Look it over and tell me what you think.

aaronbeekay commented 8 years ago

@cgreenbaum So far this is looking pretty good.

Your cell numbering is internally consistent but it is the opposite from the way the team typically numbers cells. Most designs enumerate cells, not voltages, with lower cell numbers being more negative. So your VB25 is what I would call VC1-, your VB24 is my VC1+; VB23 :: VC2+, VB1 :: VC24+.

Would you be OK with changing up your numbering/labeling to match team convention?

aaronbeekay commented 8 years ago

OK, this looks good. Once https://github.com/BuckeyeCurrent/Component-libraries/pull/96 is merged, this will be good to go.