search

buckinha / DiamondSquare

A python implementation of a diamond-square algorithm
MIT License
29 stars 8 forks source link

Python 3 #2

Closed DOsinga closed 4 years ago

DOsinga commented 6 years ago

Thanks for the implementation, this is very useful. If you would change some of the '/' to '//' to make them integer division, the code would also work for Python 3.

buckinha commented 4 years ago

Sorry i never saw this. Had been neglecting my github for a while, obviously. I'm brushing this up now, and making it py3 compatible.

DOsinga commented 4 years ago

Yeah no worries. Happy to send a code review fi you wanted to

buckinha commented 4 years ago

You're welcome to try it out if you like. Made breaking changes here. PR is here: https://github.com/buckinha/DiamondSquare/pull/3

buckinha commented 4 years ago

Tests are passing on my windows and mac machines, so i'm calling that good for the night. I've pushed to master, and the library now supports only Py3