failing to write to the twtxt file doesn't abort execution

buckket / twtxt

Decentralised, minimalist microblogging service for hackers.

http://twtxt.readthedocs.org/en/stable/

MIT License

1.92k stars 79 forks source link

failing to write to the twtxt file doesn't abort execution #33

Closed kitchen closed 8 years ago

kitchen commented 8 years ago

https://github.com/buckket/twtxt/blob/master/twtxt/cli.py#L72-L73

If that fails, a nice error message is reported and execution continues as usual, including executing the post_tweet_hook. I feel like this is incorrect behavior, and that it should abort immediately if writing the file fails.

kitchen commented 8 years ago

having a framework for surfacing runtime errors to the user in a Nice Way™ would also be useful in #32

buckket commented 8 years ago

Execution doesn't continue if add_local_tweet() returns False or raises an Exception. Will look into handling those errors more elegantly tough, especially when considering #32.