buckket / twtxt

Decentralised, minimalist microblogging service for hackers.
http://twtxt.readthedocs.org/en/stable/
MIT License
1.92k stars 79 forks source link

Create a Formula for Homebrew #50

Closed buckket closed 8 years ago

buckket commented 8 years ago

Don’t own a Mac any more, so I can’t test or write it myself, but it would be nice to have.

shakna-israel commented 8 years ago

I could take a crack at this. I have an iMac with el Capitane, atm.

buckket commented 8 years ago

Useful resources:

Plus: there are some Python CLI tools in homebrew already: https://github.com/Homebrew/homebrew/blob/7b3963ee1da7f0a4f97a28886efcff2cb88d821c/Library/Formula/httpie.rb

shakna-israel commented 8 years ago

Sorry about the time on this, just got waylaid by a couple things.

There is a question however:

Most products distributed with Homebrew tend to be cutting edge, along the lines of Gentoo.

But, I could use git tags(github releases) to do some version pinning.

Basically depends on how sure we are that the master branch won't be incredibly buggy.

Can we simply trust in the Unittests, or should we match the git tagged versions?

timofurrer commented 8 years ago

I'd highly recommend to use the official version tags.

buckket commented 8 years ago

Yeah, better use the tagged releases. Using master only leads to confusion when half-implemented or undocumented features are beging shipped to the end user.

shakna-israel commented 8 years ago

Sure thing, I'll try to link to latest.

shakna-israel commented 8 years ago

Update:

There's an open pull request at #49714.

Unfortunately, Click is causing some issues with brew-test bot.

RuntimeError: Click will abort further execution because Python 3 was configured to use ASCII as encoding for the environment.  Either run this under Python 2 or consult http://click.pocoo.org/python3/ for mitigation steps.

Just need to find a work around it not grabbing utf-8 properly:

Click discovered that you exported a UTF-8 locale

but the locale system could not pick up from it because

it does not exist.  The exported locale is "en_US.UTF-8" but it

is not supported
buckket commented 8 years ago

@shakna-israel Cool! Bet there is a way to circumvent this. But why have you listed six as a dependency for twtxt? That’s not needed! (Or has that something to do with how homebrew works?)

shakna-israel commented 8 years ago

Nope, just something that homebrew-poet picked up. I'll drop the dependency.

Just having issues with Travis only having en_US.UTF-8, but click wanting C.UTF-8... Hopefully some environment variable should be able to trick it.

buckket commented 8 years ago

Also should the test command run something that doesn’t fail as well as do something meaningful. Thinking of writing a default config file and then call twtxt -c config timeline.

buckket commented 8 years ago

Something like: https://gist.github.com/buckket/f5a09fb41d8c1712f40e (regarding the test)

This could be expanded to cover more of twtxt’s functionality, but it should do for now.

buckket commented 8 years ago

Ok, six is required by python-dateutil, missed that. So leave it there! :bow:

shakna-israel commented 8 years ago

Seems like the test builds pass now. See Jenkins 43122.

Needed to have a twtxt.txt file present, as well as the configuration.

shakna-israel commented 8 years ago

Merged in homebrew.

buckket commented 8 years ago

Thanks, @shakna-israel!