Support --since option for timeline and view cli command

buckket / twtxt

Decentralised, minimalist microblogging service for hackers.

http://twtxt.readthedocs.org/en/stable/

MIT License

1.91k stars 79 forks source link

Support --since option for timeline and view cli command #83

Closed timofurrer closed 8 years ago

timofurrer commented 8 years ago

Support --since option in timeline and view cli command. The dateparser package is used to parse the since date: https://pypi.python.org/pypi/dateparser

Examples:

twtxt timeline --since yesterday
twtxt timeline --since "1 hour ago"
twtxt view --since "Fri, 12 Dec 2014 10:55:50"

timofurrer commented 8 years ago

Any concerns about this one?

buckket commented 8 years ago

Had to revert this as dateparser has some problems with it’s setup.py that breaks stuff on RTD (UnicodeDecodeError), for example. We also would incorporate many new dependencies, will think about our possibilities here :/

timofurrer commented 8 years ago

oh, shit .. I'll figure something out asap.

Is it possible to reopen this PR?

timofurrer commented 8 years ago

Could you open an issue at the dateparser repo about that?

buckket commented 8 years ago

Apparently it’s not possible to reopen a merged PR. Will double check if the error is really caused by dateparser, i.e. if they should change something rather than say RTD.

timofurrer commented 8 years ago

Okay, thanks. Are you fine if I submit the PR again and mark it as WIP? To discuss further steps there and that no other person is working on the related issue..

buckket commented 8 years ago

Sure, go ahead! :+1: