search

buckmaxwell / github-issues-ebs

An implementation of evidence based scheduling (EBS) for github issues. This tool will integrate with Github Issues and Google Calendar and help developers and teams to accurately estimate timelines. The tool pairs well with Agile methodologies or can stand alone.
0 stars 0 forks source link

Add Rubocop #19

Open erikthiem opened 6 years ago

erikthiem commented 6 years ago

Add the Rubocop gem to the project with reasonable settings. This is needed to help maintain long-term code quality and consistency across a now multi-developer project. It will likely cause a lot of warnings (due to several very large files), which should be fixed.

@estimate: 0.25h @actual: 0.25h

buckmaxwell commented 6 years ago

What is rubucop?

On Oct 27, 2017 2:23 PM, "Erik Thiem" notifications@github.com wrote:

Add the "Rubocop" gem to the project with reasonable settings. It will likely cause a lot of warnings (due to several very large files), which should be fixed.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/buckmaxwell/github-issues-ebs/issues/19, or mute the thread https://github.com/notifications/unsubscribe-auth/AF7DlJU37-9Rk87AbClXvvxDTyQNkMFZks5swknWgaJpZM4QJog5 .

erikthiem commented 6 years ago

@buckmaxwell It's a Ruby Linter that we use quite a bit at work. You give it rules (it defaults to "official" ruby style guides) and it checks your code against those rules. Some of these include maximum method length, maximum class length, maximum line length, double vs single quotes, etc. It helps a TON with code consistency and overall project maintainability. A slight pain to get used to, but a huge timesaver long-term. Once CI it up and running, we can hook it into there so that a PR will need to pass Rubocop to get merged in.

buckmaxwell commented 6 years ago

I like it