search

buda-base / BDRC-Lib-App

5 stars 2 forks source link

swapped labels #44

Closed eroux closed 7 years ago

eroux commented 7 years ago

publisherName should be པར་གནས་ and publisherDate should be པར་དུས་, they are swapped now

eroux commented 7 years ago

@subsystem7 do you want me to swap the data between the two? I can do that so that you don't have to update the app

subsystem7 commented 7 years ago

This is what I have in the localizations file at the moment:

PublisherName:'པར་མཁན།',
PublisherDate:'པར་གནས།',
PublisherLocation:'པར་དུས།',

To me it looks like you are saying that publisherName should have the publisherDate label, and that the publisherDate should have the publisherLocation value. Is this correct? If so, what should publisherLocation be?

In the application, I am displaying these elements in this order:

<StringSection title={this.props.strings.PublisherName} val={this.props.work.publisherName} /> 
<StringSection title={this.props.strings.PublisherLocation} val={this.props.work.publisherLocation} />
<StringSection title={this.props.strings.PublisherDate} val={this.props.work.publisherDate} />

Can you confirm? I sent the translations above to @ngawangtrinley to make sure, also.

xristy commented 7 years ago

I can confirm that PublisherDate and PublisherLocation are swapped. They should be:

PublisherDate: 'པར་དུས།' , PublisherLocation: 'པར་གནས།' ,

subsystem7 commented 7 years ago

Changes made to LocalizedStrings.js