search

buda-base / BDRC-Lib-App

5 stars 2 forks source link

Inconsistent results on person names #91

Closed JannTibetan closed 3 years ago

JannTibetan commented 3 years ago

I wanted to find the person record for ཨ་ཏི་ཤ་ P3379 The search on ཨ་ཏི་ཤ་ did not yield the desired record even though this name does appear in his person record. image However searching on another of his names does yield the correct record. image

subsystem7 commented 3 years ago

@JannTibetan @ngawangtrinley I may need some help navigating the data on this to see where and how the match is being made. @eroux does this look like a data issue?

JannTibetan commented 3 years ago

@subsystem7 the two search strings are ཨ་ཏི་ཤ་ and མར་མེད་མཛད་ They are variants names of P3379

eroux commented 3 years ago

@subsystem7 this looks like a bug in the search, as persons-0.json contains

"ཨ་ཏི་ཤ":["P3379"]

so there should be a match (ignoring the punctuation according to https://github.com/buda-base/BDRC-Lib-App/issues/71 )

eroux commented 3 years ago

sorry, I didn't take the right data, this is a data problem, I'll create a new release tomorrow

eroux commented 3 years ago

I've updated the data, perhaps this would be an opportunity to test the data update system?