search

buda-base / asset-manager

Asset Manager and audit tool
The Unlicense
0 stars 0 forks source link

Does this coding mean we never override sequence length? (in FileSequence.java) #122

Closed jimk-bdrc closed 2 years ago

jimk-bdrc commented 3 years ago 
 private int getSequenceSubstringLength() {
        if (_sequenceLength == 0) {
            _sequenceLength = PropertyManager.PropertyManagerBuilder().MergeClassResource("/auditTool.properties", getClass()).getPropertyInt(this.getClass().getCanonicalName() + ".SequenceLength");
        }
        return _sequenceLength;
    }
jimk-bdrc commented 3 years ago

Yes it does. Apparently, only FileSequenceTest is the only test which uses properties. Means that a base class (and the basest of test classes) should get and save it. Or FileSequenceTest gets the value of the property (sequence length) it wants as a parameter.

jimk-bdrc commented 2 years ago

Closed in PR #159