buda-base / asset-manager

Asset Manager and audit tool
The Unlicense
0 stars 0 forks source link

More information in thumbnail test #183

Open jimk-bdrc opened 1 year ago

jimk-bdrc commented 1 year ago

Describe the bug There are two kinds of thumbnails that the EXIFImages Test reports on. When one is found, the error message should say which kind it was

To Reproduce

  1. Download WFAILEXIF.zip
  2. extract it
  3. Run audit-tool on it - Make sure that error 118 is not in the profile's ErrorsAsWarn list
  4. None of the logs (the FAIL-W209... or the log/AuditTestShell-Summary or Detail logs) says anything more than
    118,Archive Image file /.../tmp/WFAILEXIF/images/WFAILEXIF-W1/W10000001.tif contains thumbnail,/.../tmp/WFAILEXIF

Expected behavior In this case, the thumbnail was in Photoshop generated thumbnail (see below). It could also have been in an EXIF IFD1 directory. The error message should give an operator enough information about how to remove it. Screenshots or Logs

❯ exiftool WFAILEXIF/images/WFAILEXIF-W1/W10000001.tif
ExifTool Version Number         : 11.59
File Name                       : W10000001.tif
Directory                       : WFAILEXIF/images/WFAILEXIF-W1
File Size                       : 3.8 MB
File Modification Date/Time     : 2023:03:31 12:19:58-04:00
File Access Date/Time           : 2023:03:31 12:29:23-04:00
File Inode Change Date/Time     : 2023:03:31 12:19:58-04:00
File Permissions                : rw-r--r--
File Type                       : TIFF
File Type Extension             : tif
MIME Type                       : image/tiff
Exif Byte Order                 : Little-endian (Intel, II)
Subfile Type                    : Full-resolution Image
Image Width                     : 5057
Image Height                    : 6351
Bits Per Sample                 : 1
Compression                     : Uncompressed
Photometric Interpretation      : WhiteIsZero
Strip Offsets                   : 3968
Samples Per Pixel               : 1
Rows Per Strip                  : 6351
Strip Byte Counts               : 4020183
X Resolution                    : 600
Y Resolution                    : 600
Resolution Unit                 : inches
Displayed Units X               : inches
Displayed Units Y               : inches
Copyright Flag                  : False
Photoshop Thumbnail             : (Binary data 3629 bytes, use -b option to extract)
Image Size                      : 5057x6351
Megapixels                      : 32.1