buda-base / blmp-client

JS client for the BLMP
3 stars 0 forks source link

fix mixing data between different kinds of shapes #14

Closed berger-n closed 2 years ago

berger-n commented 2 years ago

fix undo when navigating multiple times from/to profile from/to open entity fix loading profile from left menu when in session at startup fix glitches when navigating between profile and other entity using left menu

berger-n commented 2 years ago

steps to reproduce:

  1. checkout branch https://github.com/buda-base/blmp-client/tree/debuglog_14
  2. close all entities/profile then reload
  3. load P1 from /new
  4. load profile
  5. click on P1
  6. clear console
  7. click on profile / user on the left

logs say it's adding personNames etc. to user via onSet/onUpdateValues listener:

Screenshot_20211104_144539

which can then be found in user undo history:

Screenshot_20211104_144804

this is related to recent changes around here: https://github.com/buda-base/blmp-client/blame/debuglog_14/src/helpers/rdf/io.ts#L325

berger-n commented 2 years ago

simpler way to reproduce, once user profile and P1 are loaded:

  1. reload from user profile
  2. click on P1
  3. clear console
  4. click on profile / user on the left

now I need to figure out why rendering EntityEditContainer for tmp:user triggers getAtomForProperty on P1 Subject: Screenshot_20211104_185346

berger-n commented 2 years ago

issue was about ensuring right shape was used with right entity when using left menu (see especially https://github.com/buda-base/blmp-client/blame/master/src/helpers/rdf/io.ts) closing

eroux commented 2 years ago

excellent, thanks a lot!

berger-n commented 2 years ago

could reproduce again:

  1. load G10
  2. load P1
  3. reload
  4. click on G10 in left menu
  5. click on P1 in left menu
  6. P1 gets modified state and some place properties are visible in its history log:

image

image

berger-n commented 2 years ago

fixed, cannot reproduce anymore, closing