search

buda-base / budax

BudaX courses and tutorials
1 stars 0 forks source link

errors in hrefs #1

Open eroux opened 2 years ago

eroux commented 2 years ago

https://github.com/buda-base/budax/commit/3f37002ab55f6f60ae5e774b8ec58acd12c10942

makes the html invalid and the href don't work anymore

ngawangtrinley commented 2 years ago

What should it be?

eroux commented 2 years ago

the issue is not the URLs, it's the html syntax, it should be

<a href="../menu/menu">

instead of

<a href="(../../menu/menu)">

this seems like an erroneous find/replace in the commit I point to: https://github.com/buda-base/budax/commit/3f37002ab55f6f60ae5e774b8ec58acd12c10942

ngawangtrinley commented 2 years ago

Corrected! you were half right. :)

It's actually <a href="../../menu/menu"> instead of <a href="(../../menu/menu)">

Here's a screenshot of DFC01 that works on the live site: image https://github.com/buda-base/budax/blob/c729941187f747ba605c6a7efebd5228c82e2e60/howtoguides/DFC01/index.html#L59

...and of DFC02 which doesn't work: image https://github.com/buda-base/budax/blob/c729941187f747ba605c6a7efebd5228c82e2e60/howtoguides/DFC02/index.html#L28