jimk-bdrc
commented
6 years ago I guess you were expecting a certain syntax in the input, while my first run had as a command line
tojsondimensions.py -I /Volumes/DRS_Staging/prod/20180403/batchWxxxxxx
And somehow the condition
'root.count(os.path.sep) == 2: # yeark…'
Was never being met.
Jim Katz Buddhist Digital Resource Center jimk@tbrc.org
On Apr 6, 2018, at 1:50 PM, Elie Roux notifications@github.com wrote:
@eroux approved this pull request.
looks good!
In contrib/tojsondimensions.py https://github.com/BuddhistDigitalResourceCenter/drs-deposit/pull/58#discussion_r179830191:
def build_lists_from_dir(dirname, outputdirname, dryrun, s3bucket):
- for root, batchdirnames, _ in os.walk(dirname):
- if root.count(os.path.sep) == 2: # yeark...
- for root, batchdirnames, fileNames in os.walk(dirname): difficult to judge just by looking, but I don't see any obvious problem, if it works that's fine for me!
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/BuddhistDigitalResourceCenter/drs-deposit/pull/58#pullrequestreview-110152243, or mute the thread https://github.com/notifications/unsubscribe-auth/Af65RTGLdYtqaXBKxOIpgQAsrX4WX0z0ks5tl6r0gaJpZM4TKZtT.
Please review these small changes I needed to make to allow arbitrary paths, and to use a PyDev project. The code is running happily on my machine.