buda-base / lds-pdi

http://purl.bdrc.io BDRC Linked Data Server
Apache License 2.0
2 stars 0 forks source link

graph/ and admindata/ not working #139

Closed eroux closed 5 years ago

eroux commented 5 years ago

the /graph/ and /admindata/ endpoints don't work correctly:

it should work just like the /resource/ endpoint (I can't find any difference actually... graph should just have a different sparql request)

eroux commented 5 years ago

I've partially fixed it, the version with extension works, the version without extension still needs fixing

MarcAgate commented 5 years ago

I believe this is working properly now. Should we close it ?

eroux commented 5 years ago

http://purl.bdrc.io/graph/W23819 still doesn't work properly (wrong mime type)

MarcAgate commented 5 years ago

What should that do ? http://purl.bdrc.io/graph/W23819 has Accept: text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,image/apng,*/*;q=0.8,application/signed-exchange;v=b3 Should I return content-type='text/turtle' in that case ?

Edit: in the /resource/{resId} case, there is a redirection to library/show/{resid}. This is not the case here so we could return text/turtle in case we have accept/html . In all other cases (accept/json or accept/turtle for instance) we would return a mime type and contents that conform to the accept header of the request.

eroux commented 5 years ago

It can be either:

anything is better than the incoherent result we currently have. If I have to pick maybe I'd pick 2, but I don't have a strong opinion

MarcAgate commented 5 years ago

Ok! so now it's either 300, 406 or 200 with trig serialization and text/trig mime (and obviously 404 when not found). http://purl.bdrc.io/graph/W23819

eroux commented 5 years ago

thanks!

MarcAgate commented 5 years ago

I just understood what you meant above so I changed the "default" Response (for accept/html) to a 302 Found with location header set to the requestUri+".trig" (http://purl.bdrc.io/graph/W23819.trig in our case)

eroux commented 5 years ago

Ok thanks!