configuration for dataset

buda-base / lds-pdi

http://purl.bdrc.io BDRC Linked Data Server

Apache License 2.0

2 stars 0 forks source link

configuration for dataset #149

Closed eroux closed 5 years ago

eroux commented 5 years ago

DILA has their own dataset configured on their Fuseki (not named bdrcrw), where is the configuration to point lds-pdi to it? It should be in /etc/buda/ldspdi (quite urgent)

MarcAgate commented 5 years ago

As the README.md file says:

Deployment on a tomcat server :
in tomcat context.xml file, add the following lines:

<Parameter name="fuseki" value="http://<server:port>/fuseki/bdrcrw/query"
         override="false"/>
<Parameter name="queryPath" value="/local/path/to/"
         override="false"/>

I don't exactly remember why it is done this way (I just recall it was related to a deployment issue) but I will investigate it. Same thing for the ldspdi.properties file that is used (it is the one in src/main/resources instead of /etc/buda/ldspdi)

eroux commented 5 years ago

But that could be overwritten in an update right? I think a file that's not in the repo (and thus cannot be updated) would be best

MarcAgate commented 5 years ago

Actually, since we decided to have local props files in dedicated (well known) directories, then the issue related to deployment is gone. Therefore I am going to adapt the code (it's getting the props through the servlet context, here) and see how it works. Same thing for the local lds-queries directory.

MarcAgate commented 5 years ago

This has been addressed in commit a3c5a6c.

eroux commented 5 years ago

thanks! So... I need to explain them what to do, but I'm not sure it's currently very clear for me... I think we should document the way to configure lds-pdi in the README. Here's a proposal:

move the API description in a separate file, maybe API.md (just copy-pasting)
add a ldspdi.properties.template file in the root of the repo, with a sensible default configuration (although no real password or key of course) and where each line is commented with its meaning. It's not really the case for now, for instance I'm not sure what PURL means as a variable

what do you think?

MarcAgate commented 5 years ago

OK. For now they can take a look at this config example (used for tests) : https://github.com/buda-base/lds-pdi/blob/master/src/test/resources/ldspdiTest.properties

eroux commented 5 years ago

well, I saw that but for someone who doesn't know the functioning of ldspdi it's way too obscure... Imagine them thinking "what's the auth graph? i don't have any, what value should I put?". It's a helpful exercice

MarcAgate commented 5 years ago

Could we close this one ?

eroux commented 5 years ago

yes, thanks