buda-base / lds-pdi

http://purl.bdrc.io BDRC Linked Data Server
Apache License 2.0
2 stars 0 forks source link

limit in text queries #159

Closed eroux closed 4 years ago

eroux commented 4 years ago

For each parameter of text queries that has isLucene=true, we currently have an extra argument which is the lang tag, for instance L_NAME -> LG_NAME. We should also have a LI_NAME which would be an integer holding the value of the limit of the text query passed to fuseki. The default (when not provided by the user) should be perhaps 1000.

So taking the example, if we have the template:

( ?s ?sc ?litC ) text:query ( skos:prefLabel ?L_NAME "highlight:" ) .

when passing the arguments L_NAME="foo"&LG_NAME=en&LI_NAME=400, the text query should look like:

( ?s ?sc ?litC ) text:query ( skos:prefLabel "foo"@en 400 "highlight:" ) .
MarcAgate commented 4 years ago

fixed as of commit 24c58bb

eroux commented 4 years ago

thanks!

eroux commented 4 years ago

I think we need to have a default value for text_query_limit somewhere though, and have it in the properties template, reopening to track it

MarcAgate commented 4 years ago

There is one in the props file. I just forgot to update the props template. Basically, either we have a LI_XXX in the query or the value set in properties file is used (and is therefore the default value for the instance). Do you think of a different logic ?

eroux commented 4 years ago

no, looks good, thanks!