buda-base / lds-pdi

http://purl.bdrc.io BDRC Linked Data Server
Apache License 2.0
2 stars 0 forks source link

volumesForInstance returns partial set for works with large number of volumes #205

Open TBRC-Travis opened 3 years ago

TBRC-Travis commented 3 years ago

I just finished syncing W2KG5013 which has 213 volumes but only the first 50 volumes are viewable on BUDA. vmb only ran against the first 50 volumes because of a partial result set from volumesForInstance.

The legacy api for this returns the proper number of image groups: https://www.tbrc.org/public?module=work&query=work-igs&args=W2KG5013

But when using the BUDA api it only returns the first 50 image groups: http://purl.bdrc.io/query/table/volumesForInstance?R_RES=bdr:W2KG5013&format=csv

eroux commented 3 years ago

Ah, right, add a pageSize argument in the end, as in

http://purl.bdrc.io/query/table/volumesForInstance?R_RES=bdr:W2KG5013&format=csv&pageSize=500

TBRC-Travis commented 3 years ago

thanks @eroux

@jimk-bdrc looks like we just need to add a pageSize argument to the api call in VolumeInfoBuda.py and rollout a new rev of bdrc-volume-manifest-builder