buda-base / lds-pdi

http://purl.bdrc.io BDRC Linked Data Server
Apache License 2.0
2 stars 0 forks source link

get Taxtree from a sparql request with a taxonomy as argument #56

Closed eroux closed 6 years ago

eroux commented 6 years ago

the Taxtree request should be adjusted to get a taxonomy as argument and give all the subnodes, that suppresses the need for a special /lib/taxtree url

MarcAgate commented 6 years ago

There is no specific Url/Rest service for taxtree: actually Taxtree.arq is one graph among other public templates (i.e http://purl.bdrc.io/graph/Taxtree is served by the same rest service as http://purl.bdrc.io/graph/IIIFPres_workGraph?R_RES=bdr:W22084, the difference being that IIIFPres_workGraph.arq requires a parameter).

Since a different taxnonomy (let's say OtherTaxonomy) will require a different sparql construct, OtherTaxonomy will be a new OtherTaxonomy.arq file.

Now, we can pass parameter(s) to graph constructs and in the case of Taxtree, we could pass the rootnode as a parameter so we would get the whole subTree having that node as root. What do you think ?

eroux commented 6 years ago

I think we should pass the root node as a parameter yes

MarcAgate commented 6 years ago

Done as of commit 4ee49d0

MarcAgate commented 6 years ago

Corrected Taxtree.arq following a bug (https://github.com/BuddhistDigitalResourceCenter/lds-queries/commit/0f4ce03bce62ff82fd56200688f45b35d27641e0)