buda-base / public-digital-library

http://library.bdrc.io
4 stars 6 forks source link

case-sensitive EWTS search #215

Closed eroux closed 4 years ago

eroux commented 4 years ago

see https://github.com/buda-base/lucene-bo/issues/26 . The problem here is a bit complex: some users will want to search in EWTS but in a sort of invalid EWTS that is case-insensitive.

For instance if they search Dgongs pa rab gsal (ཌགོངས་པ་རབ་གསལ) and find results for dgongs pa rab gsal (དགོངས་པ་རབ་གསལ). I'm reluctant to make them equivalent in the Lucene index as it's an awful lot of work and server load for little benefit... a solution I would prefer would be to essentially lower case the search in ewts in the UI unless the user does not want to. A possible UI would be:

if the query string in ewts contains an upper case letter, instead of listing just one option for wylie/ewts, we would list 2:

(in that order, the default being to lower case). If the user chooses the first option, the query is lower cased when passed in the URL, etc.

berger-n commented 4 years ago

done: image

eroux commented 4 years ago

excellent! do you display it also when there is no upper case letter in the search? (we shouldn't I think)

berger-n commented 4 years ago

no:

image

eroux commented 4 years ago

excellent! perfect