unit tests and performance tests for the label display function

buda-base / public-digital-library

http://library.bdrc.io

4 stars 6 forks source link

unit tests and performance tests for the label display function #299

Open eroux opened 3 years ago

eroux commented 3 years ago

see https://github.com/buda-base/public-digital-library/issues/297#issuecomment-712960452 . Because it's a central function, let's:

write some unit tests for it with the main use cases, so that we're sure not to screw it up during optimization
write some performance tests, just by taking a few relatively complex cases and compute the label 100 times
find the bottlenecks in the function and make it perform better

berger-n commented 3 years ago

seems to me that it performs much better now! thanks you can try it here: [edit:link to https://library.bdrc.io/view/bdr:W1KG13607] (setting page labels all at once when loading volume in reading view or opening image in OSD) do you prefer we use it as is here or I revert to syncing page labels with image lazy loading?

berger-n commented 3 years ago

BTW I tried using http://library-dev.bdrc.io/view/bdr:W1KG13607 first but thumbnails dont load a matter of data I guess?