buda-base / public-digital-library

http://library.bdrc.io
4 stars 6 forks source link

missing Chinese translations #314

Closed eroux closed 3 years ago

eroux commented 3 years ago

the "in XXX" where XXX is a type (like "in versions") is not translated in Chinese anymore when the UI is switched to zh

eroux commented 3 years ago

also, when searching with the UI in Chinese (and thus Tibetan Unicode as the main language for results in Tibetan, as opposed to Wylie):

Capture d’écran de 2020-10-29 14-27-33

berger-n commented 3 years ago

not perfect but better: http://library-dev.bdrc.io/search?q=%22mi%20la%20ras%20pa%22&lg=bo-x-ewts&t=Instance&f=asset,inc,tmp:hasOpen

image

"Note" needs a translation (bdo:biblioNote in prop, see https://github.com/buda-base/public-digital-library/blob/0846b56bd19a8e4c82f323e706c03dfc8b3cd0ce/src/translations/en.js#L169)

eroux commented 3 years ago

thanks, better indeed! I'll complete the bo and zh files tomorrow. I think the best would be to have a workflow where each time we add a translation in en, we add it (in English) in the other languages, that way it's obvious what needs to be translated. I'll make a small python script to do that though, should be easy enough