buda-base / public-digital-library

http://library.bdrc.io
4 stars 6 forks source link

Khmer UI language #719

Closed eroux closed 2 years ago

eroux commented 2 years ago

It looks like the Khmer translation of the main UI elements is done on

https://github.com/buda-base/public-digital-library/blob/master/src/translations/km.json

Perhaps we could add the Khmer language to the possible languages on the main website? (in addition to the dedicated website, which we should update with this new translation) There's also probably some translation to do for mirador?

berger-n commented 2 years ago

it's possible to enable khmer on main website, but from what I see translation of corresponding elements has not been completed:

image

I'll enable khmer in mirador as well, file will be there: https://github.com/buda-base/mirador/tree/2.7.0-bdrc/locales

berger-n commented 2 years ago

almost ready: http://library-dev.bdrc.io/

image

image

eroux commented 2 years ago

Thanks! that looks good, except on Firefox though:

Capture d’écran de 2022-06-10 18-16-37

but I don't think there's a lot we can do... this looks like a word segmentation issue, it's usually handled by ICU but it might not be activated for Firefox for some reason... I couldn't make it work even after installing some extensions, forcing lang="km" on the relevant div, etc. perhaps we could investigate that a little bit, but there's a chance it can't work at all.

I think at some point there were some discussions about creating a new topic taxonomy, but I suppose we shouldn't wait for it... @TBRC-pmench the topics are in https://github.com/buda-base/owl-schema/blob/master/schemes/taxonomy/FEMCScheme.ttl and as you can see some have a Khmer Unicode equivalent, some haven't. (some have only French / English, some have Pali, some have transliterated Khmer, etc.). Since this is very visible, perhaps we could ask Trent or Khoeun to translate / transcribe them? perhaps also the languages, etc.?

berger-n commented 2 years ago

found an easy way to merge mirador translation files and export them when deploying see https://github.com/buda-base/public-digital-library/blob/master/src/translations/km.json

https://github.com/buda-base/public-digital-library/blob/dfdbb90071acd9218197938588e13b6c88e60564/src/translations/km.json#L701-L707

berger-n commented 2 years ago

regarding Firefox we can force linebreaks like this:

image

it's not perfect from a reader's point of view, but otherwise here's what Resource page looks like:

image

what about about adding a small popup at the bottom on first visit? with link to https://bugzilla.mozilla.org/show_bug.cgi?id=1684927 or something and/or https://www.google.com/intl/en_hk/chrome/

TBRC-pmench commented 2 years ago

I think at some point there were some discussions about creating a new topic taxonomy, but I suppose we shouldn't wait for it... @TBRC-pmench the topics are in https://github.com/buda-base/owl-schema/blob/master/schemes/taxonomy/FEMCScheme.ttl and as you can see some have a Khmer Unicode equivalent, some haven't. (some have only French / English, some have Pali, some have transliterated Khmer, etc.). Since this is very visible, perhaps we could ask Trent or Khoeun to translate / transcribe them? perhaps also the languages, etc.?

Might be possible. Khoeun is under contract through September.