Monlam Dictionary integration UX feedback

[berger-n]

• [x] toggle both dictionary and etext to Wylie/uchen use icon with text on hover
• [x] dictionary on when opening viewer
• [x] fix spelling
• [x] fix bottom bar on mobile (remove dictionary)
• [x] open/close image instead of reading view when click on image

[edit: fix spelling + dictionary on when opening viewer (#800) ]

[berger-n]

• Cmd+C should work now on Mac @evanyerburgh everything else as well: https://library.bdrc.io/show/bdr:UTIE0OPI44484488_I3CN3541?backToEtext=bdr:IE0OPI44484488&backToEtext=bdr:UTIE0OPI44484488_I3CN3541#open-viewer

  

---

• regarding dictionary icon/text redundancy though, I'm not sure what to do as this icon+text(+checkbox when needed) pattern is in use elsewhere in the site, see for example the image viewer top/bottom bars: https://library.bdrc.io/show/bdr:W22084#open-viewer

  

  as long as there's space to display text why not show it? especially when the meaning of an icon (like Monlam logo or Etext in the screenshot above) is not as straightforward to get as the download button

---

• image viewer bottom bar needs to be fixed when between 800 and 900px:

[evanyerburgh]

@berger-n Great! Yep, Control+C works for me now.

as long as there's space to display text why not show it?

I agree. And I like how when the browser window gets narrower, they drop down to icons.

Testing it just now, I noticed two more things about narrow screens...

• Monlam doesn't show up on my android phone.
• When I made my window narrower, the Monlam option disappeared.

Here's a screencast from my computer. Notice also that when I highlighted text while the browser is narrow, it didn't unselect the previously selected text (which you can see when the window gets wider again.)

https://user-images.githubusercontent.com/51434640/221777768-a3629f9a-ae3b-4b90-869b-6083f92a90e1.mp4

[berger-n]

dictionary now enabled on mobile, you can test it here: http://library-dev.bdrc.io/show/bdr:UTIE0OPI44484488_I3CN3541?backToEtext=bdr:W3CN3328#open-viewer click on "Copy" after selecting text to open Monlam popup (not perfect in terms of UX as it sure needs to be documented, but it does not seem possible for a website to add an option in a mobile's native contextual menu I'm afraid)

oh and I added swipe support for closing both Monlam results panel and the bottom bar (which close button is really small)

[eroux]

very nice, thanks!!

[evanyerburgh]

Awesome, looks great! Thanks, Nicolas

[JannTibetan]

when searching within etexts, the initial search string is highlighted in the etext. This is a wonderful. However, this highlighted text cannot be subsequently highlighted by the Monlam Dictionary feature.

https://user-images.githubusercontent.com/44705185/222219471-fcfc2c35-3c65-4336-9cf4-4c84ba6db547.mov

[berger-n]

oh that's surprising, thanks! actually it already can on my computer though (using Chrome): link

---

but let me check what's going on in Safari! (or is it Firefox?)

[berger-n]

ah it works for me in Safari as well...

[JannTibetan]

OK it did work for me once on Safari but most of the time it doesn't. It works very smoothly on Firefox. Anyway, this is an incredible new feature. People will certainly ask why they can't just query the dictionary directly but this is samsara and desires are endless...

[eroux]

well, they can on https://monlamdic.com/ ... but it's true that we don't have a link... perhaps the at the top of the results could have a link to it?

[berger-n]

OK it did work for me once on Safari but most of the time it doesn't.

it is intriguing... I'll dig into this

well, they can on https://monlamdic.com/ ... but it's true that we don't have a link... perhaps the at the top of the results could have a link to it?

(actually the title & icon at the top of the results are already links to monlamdic.com)

[berger-n]

• @JannTibetan can you test this update: \<link to library-dev>

  

  you'll see that when dictionary mode is on, hovering on a page with some keyword makes the highlighting disappear (it disappears when you click anywhere on the page as well) this should fix the issue with Safari that I cannot reproduce

• @eroux I've also implemented the first two items of @ngawangtrinley 's feedback:

  • dictionary won't close if you click anywhere on the page (you have to click the dedicated button in the top-right corner)
  • once dictionary panel is open you just have to select text to show results (no popup to click anymore)
  • not implemented the third one yet (limiting the maximum number of syllables to send to dictionary) what should be the limit? 20 syllables? 30?

[berger-n]

@eroux what about a new sort by "quality" on the etext results page?

• we could use OCR Mean Confidence Index when available
• 1 in the case of computer input?
• 0.999 for bdo:OPFOCRSoftware "norbuketaka"?

[eroux]

good idea! Thanks for the changes, I think a good limit could be pretty high, let's start maybe at 40

[JannTibetan]

@berger-n I tested the link you sent and it works well on Safari. Thanks

[berger-n]

• added both a "quality" facet (with label NEW, open when loading page) and a "sort by quality" option, not sure about the wording: \<link>

• there's now a maximum length allowed for the text selection used by dictionary (arbitrarily set limit to 80 chars because handling a number of syllables was not that straightforward... :sweat_smile:): \<link>

[eroux]

this is great, thanks! perhaps 120 characters is safer. Also, maybe "OCR quality" would be good?

[JannTibetan]

Or, "accuracy (ranking)" Quality is probably not self explanatory enough.

[berger-n]

thanks @JannTibetan! what about simplifying these labels for filter values as well? something like this: \

[JannTibetan]

Sure. Great idea. Filters are much more visible than rankings so let's build in some redundancy about this so that people know what to expect from the texts. Thanks.

[eroux]

LGTM, thanks!