new etext viewer

[eroux]

let's make an etext viewer that is an overlay on the website, just like the image viewer. I believe we have everything we need in terms of queries but I'm not sure. In terms of design we can just reuse the image viewer / DLD design

[berger-n]

some progress:

• https://library-dev.bdrc.io/show/bdr:IE0OPI6440489A

• https://library-dev.bdrc.io/show/bdr:IE1KG14

---

needs more polishing (button to toggle the outline, fix close button in top bar, handle links from search results like this, and more to come)

[eroux]

wow this is really a great start!! thanks a lot!

[berger-n]

not far from finished here: some etext search results

• now let's maybe open the first text by default when none is already selected?
• and open/highlight current text in outline panel
• display both outline and text either in Unicode or Wylie
• (+ don't display the first pages twice :sweat_smile: )

do you see anything else @roopeux @eroux ?

[eroux]

wow you did a great job, thank you so much!

I don't see anything else beyond your list, one important aspect will be downloading easily (it's a very common use case), let's make sure it's possible from the outline (as it was before).

There are a few other improvements for the etext viewer but they're not related to this issue, I'll open one or two more but they're comparatively much smaller.

[berger-n]

all done: link to etext from search results

• [x] open the first text by default when none is already selected
• [x] open current text in outline panel
• [x] don't display the first pages twice
• [x] ~display both outline and text either in Unicode or Wylie~ [edit: oops I forgot, the outline still doesn't use the etext setting]

a few more glitches and we're good here

• reset first page displayed when switching volume in a search result
• keep displaying/hiding scans once it has been checked/unchecked

[berger-n]

all fixed, ready to move on (to #864) [real-time edit: found one more bug, see at the bottom...]:

• same link to etext from search results

  

---

• https://library-dev.bdrc.io/show/bdr:IE1KG14557

  

  not sure what's happening but can't download here...

  + see volume 3 has no pagination? not even available on library: https://library.bdrc.io/show/bdr:IE1KG14557 but that could be related to a typo in RID like: https://ldspdi.bdrc.io/query/graph/etextrefs?R_RES=bdr%3AIE1KG14557

[eroux]

This is really great!! Yes these etexts (from Namsel, almost 10 years ago) have a lot of bugs, they should be withdrawn but I'm just waiting for the Google Books update

[berger-n]

(just found out that my ad blocker chrome extension prevented the etexts to be downloaded, maybe we should warn the user about that somehow?)

[eroux]

oh really?? weird... what extension is it? Do you understand why it blocks it?

[berger-n]

the extension is https://chromewebstore.google.com/detail/adblocker-stands/lgblnfidahcdcjddiepkckcfdhpknnjh?pli=1 actually it makes sense because we are programmatically triggering a click on a download link (last line):

https://github.com/buda-base/public-digital-library/blob/eb2fb94584fff5cc67384b2f7946af5016208875/src/components/App.js#L940-L958

[eroux]

oh I see! is there a way to avoid that? we can ask the user to click again or something perhaps?

[berger-n]

https://github.com/buda-base/public-digital-library/commit/3b6c09e6191fa7372d6765c9dfcae225ea8825ef adds a popup only visible when the click/download is not automatically triggered:

---

now my problem actually was that the css of the ad blocker is not "compatible" with ours (it was hidden behind our topbar!) here's what happens now, more self-explanatory:

---

should I always enable the "Save downloaded file" popup? or assume that ad blocker developers use the highest possible z-index so that their own confirmation popup is on top of anything else on the screen :sweat_smile:

[berger-n]

(I mean, the ad blocker disables even the "Save downloaded file" popup if I attempt to trigger the click on the download link, so it's either all or nothing)