buda-base / public-digital-library

http://library.bdrc.io
5 stars 6 forks source link

Clear filters with new search (for test) #930

Open berger-n opened 2 months ago

berger-n commented 2 months ago

When user has selected some filters and does a new search, we should clear the filters.

(There are UX arguments for both clearing and not clearing, but clearing seems to be the lesser evil.)

berger-n commented 2 months ago

done: link (could add a Clear all filters button along the way, but tell me what you think about it @roopeux)

simplescreenrecorder-2024-09-13_17 33 40 mkv


BTW @eroux where should I report this in the search above, coming from the query results:

image

image

eroux commented 2 months ago

ah yes that's quite funny... can you report it on https://github.com/buda-base/autocomplete-prototype ?

roopeux commented 2 months ago

We need to clear all filters when the user searches again. The button will not be enough alone, although it is good to have it.

berger-n commented 2 months ago

that's already the case, a new search gets results without any filter, and there's a button to clean them too or I am mistaken?

eroux commented 2 months ago

@berger-n on your link if I remove the last syllable and press enter, I get to this link which still has the filters, I think that's what @roopeux is describing

berger-n commented 2 months ago

oh I get it thanks, sorry! I'll fix that, it only works with autosuggestions for now

berger-n commented 2 months ago

should work now: link

simplescreenrecorder-2024-09-16_11 06 00 mkv

roopeux commented 2 months ago

It is good enough now. The UX is still a bit problematic, because the filters show as checked but the search is done without them, but Amazon seems to have the same issue. They grey out the whole page now during typing. Let's see if the test reveals something.