buddhi1980 / mandelbulber2

Official repository for Mandelbulber v2
GNU General Public License v3.0
909 stars 115 forks source link

Backwards compatability relating to bailout fix #742

Open mclarekin opened 4 years ago

mclarekin commented 4 years ago

Refer Issue #685 and comit https://github.com/buddhi1980/mandelbulber2/commit/8f3f272550ae5aab3b2deb0e513be2553e281a34

My latest test for general backwards compatibility issues related to the fix in bailout code, appears to show a major difference in color with pseudoKleinian in hybrid mode.

Please check the latest settings above in openCL mode for reproducibility.

we can : a) advise users and add no backwards compatibilty code b) we can rename preV2.15 orbit color to pre v2.20 color and use it to access backwards compatibilty code

buddhi1980 commented 4 years ago

In exactly which settings do you see difference? When I try latest settings and remove recently added additional bailout check, image looks exactly the same.

buddhi1980 commented 4 years ago

I have compared all settings rendered in July and 2 days ago. There are no differences in coloring.

mclarekin commented 4 years ago

it looks like it might only happen with pseudoKleinianDE

mclarekin commented 4 years ago

this is a new test for aux.color, hybrid mode - extra hybrid mode controls - only aux.color active. Latest build shows some minor differenec with openCL

a) ignore c++ difference as assume c++ is seldom used b) in hybrid mode, we can assume that most users do not use extra hybrid mode controls, therefore their color is also contains orbitTrap color, so the difference would be less obvious in a lot of cases. I will do some more testing, but my current feeling is that the backwards compatibilty issue can be ignored. (it should only effect a few users, who can always use V2.19 if they want to re-render an old image)

Mandelbulber settings file

version 2.20

only modified parameters

[main_parameters] ambient_occlusion_enabled true; background_3_colors_enable false; background_color_1 0000 aa00 ff00; camera -5.073483504217775 -6.934375902948554 3.437892053324262; camera_distance_to_target 3.735248565673828; camera_rotation 0 0 0; camera_top 0 0 1; constant_DE_threshold true; DE_factor 0.5; DE_thresh 0.001112271707301139; delta_DE_function 5; dont_add_c_constant_2 true; flight_last_to_render 0; formula_1 2104; formula_2 125; formula_3 2104; formula_iterations_2 7; formula_stop_iteration_2 9; fov 0.5; fractal_enable_3 false; glow_enabled false; hybrid_fractal_enable true; image_proportion 3; image_width 900; keyframe_last_to_render 0; mat1_coloring_palette_offset 10.01; mat1_fractal_coloring_aux_color_false true; mat1_fractal_coloring_extra_color_enabled_false true; mat1_fractal_coloring_orbit_trap_scale1 0; mat1_fractal_coloring_orbit_trap_true false; mat1_fractal_coloring_orbit_trap_weight 3.9; mat1_fractal_coloring_rad_div_de_scale1 0; mat1_fractal_coloring_rad_div_de_weight 19.5; mat1_fractal_coloring_xyzC_111 0 0 1; mat1_is_defined true; mat1_specular 1; mat1_specular_plastic_enable false; mat1_specular_width 1; mat1_surface_color 3600 5500 3300; mat1_surface_color_gradient 0 fd6029 999 698403 1999 aa0000 2999 f5bd22 3999 0b5e87 5000 c68876 5999 00ffff 7000 3b9fee 7955 aa0000 9000 aba53c; N 52; raytraced_reflections true; target -5.073483504217775 -3.199127337274727 3.437892053324262; view_distance_max 168.117903318534; volumetric_fog_colour_1_distance 0.03125; volumetric_fog_colour_2_distance 0.0625; volumetric_fog_density 0.125; volumetric_fog_distance_factor 0.0625; [fractal_1] boxfold_bulbpow2_z_factor 1; fold_color_difs1 0.9; mandelbox_color 0 1.85 0; mandelbox_color_Sp1 0; mandelbox_main_rotation_enabled true; mandelbox_scale 1.2; transf_addition_constant 0 0 0.3; transf_addition_constant_0555 1 1 1; transf_folding_limit 0.9; transf_function_enabled_false true; transf_function_enabledAz_false true; transf_function_enabledB_false true; transf_function_enabledBx false; transf_function_enabledBy false; transf_function_enabledBy_false true; transf_function_enabledD_false true; transf_function_enabledK_false true; transf_function_enabledM false; transf_function_enabledM_false true; transf_function_enabledz_false true; transf_minimum_radius_05 0; transf_minR2_p25 0; transf_offset_001 0 0 1.7; transf_offset_002 0 0 1.7; transf_offset_05 0; transf_offset_1 2; transf_offset_111 1 1 3; transf_offset_2 1; transf_offsetA_0 1.2; transf_offsetA_1 1.5; transf_offsetA_2 1.2; transf_offsetE_2 0.7; transf_offsetF_2 1.2; transf_scale_2 1.2; [fractal_2] fold_color_difs1 0.2; mandelbox_color 0 0 0.07000000000000001; mandelbox_color_Sp1 0; mandelbox_color_Sp2 0; mandelbox_main_rotation_enabled true; mandelbox_scale 1.1; transf_addition_constant 0 0 0.3; transf_addition_constant_0555 1 1 1; transf_folding_limit 0.9; transf_function_enabledAz_false true; transf_function_enabledBx false; transf_function_enabledBy false; transf_function_enabledBy_false true; transf_function_enabledK_false true; transf_function_enabledM false; transf_function_enabledz_false true; transf_minR2_p25 0; transf_offset_001 0 0 3; transf_offset_002 0 0 1.7; transf_offset_05 0; transf_offset_1 2; transf_offset_111 1 1 3; transf_offset_2 0.9999999999999997; transf_offsetA_0 2.7; transf_offsetA_1 1.5; transf_offsetA_2 1.199999999999999; transf_offsetB_0 2; transf_scale_2 1.2; transf_start_iterations_A 6; transf_start_iterations_M 4; transf_stop_iterations_A 7; transf_stop_iterations_C 7; transf_stop_iterations_X 7; [fractal_3] transf_function_enabledAx false; transf_function_enabledAy false; transf_function_enabledBz_false true; transf_function_enabledG_false true; transf_function_enabledM false; transf_function_enabledR_false true; transf_function_enabledSw_false true; transf_function_enabledX_false true; transf_offset_0005 0.01; transf_radius_1 0.6; transf_rotation 0 0 30;

auxColor

mclarekin commented 4 years ago

color by numbers -colorValue iteration components. Bailout fix has corrected this, top images are c++ and openCL, bottom image is now what we get in both modes Backwards compatibilty is very very minor because i assume nobody uses it.

Mandelbulber settings file

version 2.20

only modified parameters

[main_parameters] ambient_occlusion_enabled true; background_3_colors_enable false; background_color_1 0000 aa00 ff00; camera -5.073483504217775 -6.934375902948554 3.437892053324262; camera_distance_to_target 3.735248565673828; camera_rotation 0 0 0; camera_top 0 0 1; constant_DE_threshold true; DE_factor 0.5; DE_thresh 0.001112271707301139; delta_DE_function 5; dont_add_c_constant_2 true; flight_last_to_render 0; formula_1 2104; formula_2 125; formula_3 2104; formula_iterations_2 7; formula_stop_iteration_2 9; fov 0.5; fractal_enable_3 false; glow_enabled false; hybrid_fractal_enable true; image_proportion 3; image_width 900; keyframe_last_to_render 0; mat1_coloring_palette_offset 10.01; mat1_fractal_coloring_extra_color_enabled_false true; mat1_fractal_coloring_iter_group_enabled_false true; mat1_fractal_coloring_orbit_trap_scale1 0; mat1_fractal_coloring_orbit_trap_true false; mat1_fractal_coloring_orbit_trap_weight 3.9; mat1_fractal_coloring_rad_div_de_scale1 0; mat1_fractal_coloring_rad_div_de_weight 19.5; mat1_fractal_coloring_xyzC_111 0 0 1; mat1_is_defined true; mat1_specular 1; mat1_specular_plastic_enable false; mat1_specular_width 1; mat1_surface_color 3600 5500 3300; mat1_surface_color_gradient 0 fd6029 999 698403 1999 aa0000 2999 f5bd22 3999 0b5e87 5000 c68876 5999 00ffff 7000 3b9fee 7955 aa0000 9000 aba53c; N 52; raytraced_reflections true; target -5.073483504217775 -3.199127337274727 3.437892053324262; view_distance_max 168.117903318534; volumetric_fog_colour_1_distance 0.03125; volumetric_fog_colour_2_distance 0.0625; volumetric_fog_density 0.125; volumetric_fog_distance_factor 0.0625; [fractal_1] boxfold_bulbpow2_z_factor 1; fold_color_difs1 0.9; mandelbox_color 0 1.85 0; mandelbox_color_Sp1 0; mandelbox_main_rotation_enabled true; mandelbox_scale 1.2; transf_addition_constant 0 0 0.3; transf_addition_constant_0555 1 1 1; transf_folding_limit 0.9; transf_function_enabled_false true; transf_function_enabledAz_false true; transf_function_enabledB_false true; transf_function_enabledBx false; transf_function_enabledBy false; transf_function_enabledBy_false true; transf_function_enabledD_false true; transf_function_enabledK_false true; transf_function_enabledM false; transf_function_enabledM_false true; transf_function_enabledz_false true; transf_minimum_radius_05 0; transf_minR2_p25 0; transf_offset_001 0 0 1.7; transf_offset_002 0 0 1.7; transf_offset_05 0; transf_offset_1 2; transf_offset_111 1 1 3; transf_offset_2 1; transf_offsetA_0 1.2; transf_offsetA_1 1.5; transf_offsetA_2 1.2; transf_offsetE_2 0.7; transf_offsetF_2 1.2; transf_scale_2 1.2; [fractal_2] fold_color_difs1 0.2; mandelbox_color 0 0 0.07000000000000001; mandelbox_color_Sp1 0; mandelbox_color_Sp2 0; mandelbox_main_rotation_enabled true; mandelbox_scale 1.1; transf_addition_constant 0 0 0.3; transf_addition_constant_0555 1 1 1; transf_folding_limit 0.9; transf_function_enabledAz_false true; transf_function_enabledBx false; transf_function_enabledBy false; transf_function_enabledBy_false true; transf_function_enabledK_false true; transf_function_enabledM false; transf_function_enabledz_false true; transf_minR2_p25 0; transf_offset_001 0 0 3; transf_offset_002 0 0 1.7; transf_offset_05 0; transf_offset_1 2; transf_offset_111 1 1 3; transf_offset_2 0.9999999999999997; transf_offsetA_0 2.7; transf_offsetA_1 1.5; transf_offsetA_2 1.199999999999999; transf_offsetB_0 2; transf_scale_2 1.2; transf_start_iterations_A 6; transf_start_iterations_M 4; transf_stop_iterations_A 7; transf_stop_iterations_C 7; transf_stop_iterations_X 7; [fractal_3] transf_function_enabledAx false; transf_function_enabledAy false; transf_function_enabledBz_false true; transf_function_enabledG_false true; transf_function_enabledM false; transf_function_enabledR_false true; transf_function_enabledSw_false true; transf_function_enabledX_false true; transf_offset_0005 0.01; transf_radius_1 0.6; transf_rotation 0 0 30;

colrValue_iteration_components

mclarekin commented 4 years ago

BoxBulb in hybrid mode, RadDivDE, minor difference, , has improved BUT I suspect no users would have ever had used this type of setting

Mandelbulber settings file

version 2.20

only modified parameters

[main_parameters] ambient_occlusion_enabled true; background_3_colors_enable false; background_color_1 0000 aa00 ff00; camera -5.073483504217775 -6.934375902948554 3.437892053324262; camera_distance_to_target 3.735248565673828; camera_rotation 0 0 0; camera_top 0 0 1; constant_DE_threshold true; DE_factor 0.5; DE_thresh 0.001112271707301139; dont_add_c_constant_1 true; flight_last_to_render 0; formula_1 125; fov 0.5; glow_enabled false; hybrid_fractal_enable true; image_proportion 3; image_width 900; keyframe_last_to_render 0; mat1_coloring_palette_offset 10.01; mat1_fractal_coloring_aux_color_scale1 0; mat1_fractal_coloring_extra_color_options_false true; mat1_fractal_coloring_init_cond_enabled_false true; mat1_fractal_coloring_orbit_trap_scale1 0; mat1_fractal_coloring_orbit_trap_true false; mat1_fractal_coloring_orbit_trap_weight 3.9; mat1_fractal_coloring_rad_div_de_scale1 1024; mat1_fractal_coloring_rad_div_de_weight 19.5; mat1_fractal_coloring_xyzC_111 0 0 1; mat1_is_defined true; mat1_specular 1; mat1_specular_plastic_enable false; mat1_specular_width 1; mat1_surface_color 3600 5500 3300; mat1_surface_color_gradient 0 fd6029 999 698403 1999 aa0000 2999 f5bd22 3999 0b5e87 5000 c68876 5999 00ffff 7000 3b9fee 7955 aa0000 9000 aba53c; N 52; raytraced_reflections true; target -5.073483504217775 -3.199127337274727 3.437892053324262; view_distance_max 168.117903318534; volumetric_fog_colour_1_distance 0.03125; volumetric_fog_colour_2_distance 0.0625; volumetric_fog_density 0.125; volumetric_fog_distance_factor 0.0625; [fractal_1] mandelbox_color 0 0 0.07000000000000001; mandelbox_color_Sp1 0; mandelbox_color_Sp2 0; transf_minR2_p25 0; transf_start_iterations_A 7; transf_stop_iterations_A 58; transf_stop_iterations_B 17; transf_stop_iterations_C 8; transf_stop_iterations_S 7; [fractal_2] fold_color_difs1 0.2; mandelbox_color 0 0 0.07000000000000001; mandelbox_color_Sp1 0; mandelbox_color_Sp2 0; mandelbox_main_rotation_enabled true; mandelbox_scale 1.1; transf_addition_constant 0 0 0.3; transf_addition_constant_0555 1 1 1; transf_folding_limit 0.9; transf_function_enabledAz_false true; transf_function_enabledBx false; transf_function_enabledBy false; transf_function_enabledBy_false true; transf_function_enabledK_false true; transf_function_enabledM false; transf_function_enabledz_false true; transf_minR2_p25 0; transf_offset_001 0 0 3; transf_offset_002 0 0 1.7; transf_offset_05 0; transf_offset_1 2; transf_offset_111 1 1 3; transf_offset_2 0.9999999999999997; transf_offsetA_0 2.7; transf_offsetA_1 1.5; transf_offsetA_2 1.199999999999999; transf_offsetB_0 2; transf_scale_2 1.2; transf_start_iterations_A 7; transf_start_iterations_M 4; transf_stop_iterations_A 58; transf_stop_iterations_B 7; transf_stop_iterations_C 7; transf_stop_iterations_S 7; transf_stop_iterations_X 7;

radDivDE v