buddhi1980 / mandelbulber2

Official repository for Mandelbulber v2
GNU General Public License v3.0
909 stars 115 forks source link

Shape size for 'line' orbit traps should control line's length, but doesn't #775

Open ghost opened 4 years ago

ghost commented 4 years ago
System information (version)
Detailed description

It would seem, from my personal testing, that the shape size parameter for line-type orbit trap lights has no effect. This parameter should be able to control the line's length, and maybe 0 or -1 should set it to the current behavior (of an infinite-length line.)

Steps to reproduce

Use any orbit trap lights with line shape.

buddhi1980 commented 4 years ago

You are right. It has no effect. It is a good idea to use it to define length of the line.

ghost commented 4 years ago

When upgrading, don't forget to change interpret all existing formulas using line orbit traps to set the length to infinite. It could break some files otherwise.

mclarekin commented 4 years ago

a) alternatively a line can be viewed as a cylinder with a very small radius b) a line of fixed length has orbittrap distances at right angles along the length and radial orbitrap distances past the ends, For similar maths https://www.youtube.com/watch?v=PMltMdi1Wzg

mclarekin commented 4 years ago

a) clarify, size could be radius instead of length, then we have an infinte tube

General, tube or cylinder are quite cheap, but there is a lot more orbittrap lights we could implement but they are more expensive and i would consider them very low on the programs TODO priority list