buddhi1980 / mandelbulber2

Official repository for Mandelbulber v2
GNU General Public License v3.0
894 stars 116 forks source link

[Suggestion] Offer to delete asociated images when removing keyframe #882

Open degriz opened 3 years ago

degriz commented 3 years ago

What it says..

buddhi1980 commented 3 years ago

Which frames should be deleted? From deleted keyframe to the end? Deleting keyframe affects all keyframes after deleted one.

mclarekin commented 3 years ago

i think it is delete rendered frames either side of deleted keyframe to where the interpolation will not change the image. This is dependent on the interpolation method ie if 30 frames per keyframe then with linear we only need to remove 29 images before plus the keyframe image, and 29 after, and there are no frames to be re-rendered

. Whereas other interpolations may require 3 times this amount of images to be removed, plus the re-rendering of images affected by interpolation

Basically automating what we have to do manually.

Nice to have but of low priority on the to do list

On Thu, Sep 9, 2021 at 6:40 AM Krzysztof Marczak @.***> wrote:

Which frames should be deleted? From deleted keyframe to the end? Deleting keyframe affects all keyframes after deleted one.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/buddhi1980/mandelbulber2/issues/882#issuecomment-915479091, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADBNSHFA6DWRU3L6VFU3HZ3UA6UZPANCNFSM5DSDUJ2A . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

degriz commented 3 years ago

Just the frames from that key. Otherwise they get left behind and confuse the count. End up with lumps of prior version.

mclarekin commented 3 years ago

I am still confused. "Just the frames from that key". From (forward?) or belonging to?

If you delete a keyframe, it has a ripple effect with cubic interpolation.

So if at 30 frames per keyframe, and you delete a keyframe, how many associated frames do you want removed?

On Thu, Sep 9, 2021 at 9:14 PM degriz @.***> wrote:

Just the frames from that key. Otherwise they get left behind and confuse the count. End up with lumps of prior version.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/buddhi1980/mandelbulber2/issues/882#issuecomment-915908915, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADBNSHGIH3TZK2FNJRW6R4LUBB3HFANCNFSM5DSDUJ2A . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

buddhi1980 commented 3 years ago

There is bigger issue. If I delete keyframe and frames after it are already rendered, then frame indexes will no longer correspond to keyframe indexes after deleted keyframe.

TasMania17 commented 2 years ago

A Mandelbulber animation is a .fract file. The images rendered are stored outside Mandelbulber in the 'path for images' folder. Keyframes can be dropped as long as you 'refresh table'. That rebuilds indexes in the fract file only as far as I know.

If a keyframe is discarded after it's images are rendered then it looks like a file manager operation to delete the frames it produced and all subsequent frames. (Unless you want to get into messy file operations of re-numbering frames and syncing with the fract file). You need to get it right before rendering :)

I've made Mandelbulber animations and if you don't like a series of frames then drop another animation stream over the top of them in your video editing software. I don't think Mandelbulber should have to find 4 different types of image files and their alpha channels because it's a fractal rendering program.