search

buddy-compiler / buddy-benchmark

Benchmark Framework for Buddy Projects
Apache License 2.0
44 stars 34 forks source link

Added REPLICATE_PADDING boundary option #39

Closed amanchhaparia closed 2 years ago

amanchhaparia commented 2 years ago

This PR intends to add the boundary option of BORDER_REPLICATE while benchmarking correlation2D.

closes #31

amanchhaparia commented 2 years ago

@meshtag, I have added BORDER_REPLICATE boundary option which will run by default, but I am planning to add a CLI option to choose the boundary option. I have 2 doubts regarding it:

  1. In main.cpp, here what are the extra arguments apart from image_path and kernel?
  2. While benchmarking different boundary option, Here, I am bit stuck how to register/run particular benchmarking function based on the CLI argument. I would be great if you can provide bit of its insight.
meshtag commented 2 years ago

Thanks for your work @amanchhaparia !

In main.cpp, here what are the extra arguments apart from image_path and kernel?

I am not really sure, it might be redundant at this stage (should've documented its usage).

While benchmarking different boundary option, Here, I am bit stuck how to register/run particular benchmarking function based on the CLI argument. I would be great if you can provide bit of its insight.

Perhaps you can try this by creating a global flag in BuddyCorr2DBenchmark.cpp, change this flag's value inside initializeBuddyCorr2D based on provided CLI arguments. Then check this flag's value while registering the benchmark function.

amanchhaparia commented 2 years ago

@meshtag, Thanks for the guidance! I have updated the conditional statement in main.cpp, since the other arguments are maybe redundant. PR is ready for review.

amanchhaparia commented 2 years ago

@meshtag, PR is updated as per the requested suggestions.