[feature] new img container support PNG

buddy-compiler / buddy-mlir

An MLIR-based compiler framework bridges DSLs (domain-specific languages) to DSAs (domain-specific architectures).

https://buddy-compiler.github.io/

Apache License 2.0

514 stars 167 forks source link

[feature] new img container support PNG #380

Closed Hanyonggong closed 3 weeks ago

Hanyonggong commented 2 months ago

New img container support PNG based on libpng

Supports PNG images in all formats
Maintain the code style of the new container (like BMP support) in order to abandon libpng in the future
It have passed the Lenet model test

To compile target buddy-new-image-container-test:

$ cd buddy-mlir $ mkdir build $ cd build $ cmake -G Ninja .. \ -DMLIR_DIR=$PWD/../llvm/build/lib/cmake/mlir \ -DLLVM_DIR=$PWD/../llvm/build/lib/cmake/llvm \ -DLLVM_ENABLE_ASSERTIONS=ON \ -DCMAKE_BUILD_TYPE=RELEASE -DBUDDY_MLIR_ENABLE_DIP_LIB=ON $ ninja

LiuYang328 commented 1 month ago

Because of the new dependencies and changes to the cmake file, a new version README is needed to guide users build with new container

Hanyonggong commented 1 month ago

Because of the new dependencies and changes to the cmake file, a new version README is needed to guide users build with new container

The build commands for the examples has not changed, but the build command for test has changed

LiuYang328 commented 1 month ago

Because of the new dependencies and changes to the cmake file, a new version README is needed to guide users build with new container

The build commands for the examples has not changed, but the build command for test has changed

when i build buddy-mlir, i have to enable BUDDY_MLIR_ENABLE_DIP_LIB, otherwise, the build won't succeed. It's best to explain this in the pr.

Hanyonggong commented 1 month ago

when i build buddy-mlir, i have to enable BUDDY_MLIR_ENABLE_DIP_LIB, otherwise, the build won't succeed. It's best to explain this in the pr.

Thank you for your question. I have updated the PR to prevent compilation failure due to unspecified parameters

LiuYang328 commented 1 month ago

Does libpng have specific version requirements? My current version is 1.6.37

when i use new container in MobileNet example, I meet this error

Can you try the MobileNet example on your side ? Thank you !

Hanyonggong commented 1 month ago

Does libpng have specific version requirements? My current version is 1.6.37

when i use new container in MobileNet example, I meet this error

Can you try the MobileNet example on your side ? Thank you !

Please refer to the Lenet's CMakeLists.txt for the correct link to the libpng library