buddycloud / buddycloud-media-server

Share files in a buddycloud channel
http://buddycloud.com
28 stars 16 forks source link

Authorization header not required for GET requests? #66

Closed martin-hewitt closed 10 years ago

martin-hewitt commented 10 years ago

The docs in section https://github.com/buddycloud/buddycloud-media-server#sending-the-http-request indicate that an Authorization header is necessary for GET requests.

I can GET images from the https://demo.buddycloud.org API without this Authorization header.

Are the docs wrong or is the server misconfigured?

abmargb commented 10 years ago

If the media belongs to a public channel, or it is an avatar, you don't need the Authorization header.

martin-hewitt commented 10 years ago

Ah, ok, that makes sense. Might be worth noting that in the docs, as, if a user is building a front-end interface to the media server, an open channel, with freely available images, means just creating an <img> tag, whereas a closed channel, with authenticated images, is much more complex.

abmargb commented 10 years ago

Good point. I'm adding this to the docs.