buddycloud / buddycloud-server-java

The buddycloud server written in Java.
http://buddycloud.com
Apache License 2.0
67 stars 40 forks source link

Implement tombstones for deleted items #63

Open ashward opened 11 years ago

lloydwatkin commented 10 years ago

http://tools.ietf.org/html/draft-snell-atompub-tombstones-18

imaginator commented 10 years ago

I'm not convinced about tombstoning child posts.

Imagine a controversial thread (and popular) being commented on risks being wiped out by the original poster trying to flush something down the history hole (it happens http://www.theguardian.com/politics/2013/nov/13/conservative-party-archive-speeches-internet)

+1 on the "who deleted" (when should come from the atom entry) +1 on notifications

On 13 November 2013 16:02, Lloyd Watkin notifications@github.com wrote:

http://tools.ietf.org/html/draft-snell-atompub-tombstones-18

  • Also tombstone child items if post is a topic (rather than a comment)
  • Notifications of updated posts should be send out to subscribers
  • Would be useful to include details about the user who deleted the post and when it was deleted

— Reply to this email directly or view it on GitHubhttps://github.com/buddycloud/buddycloud-server-java/issues/63#issuecomment-28401123 .

Simon Tennant | buddycloud.com | +49 17 8545 0880 | office hours: goo.gl/tQgxP

lloydwatkin commented 10 years ago

The thing is, we'd never show the child posts in the UI (or would we?) so why no tombstone them? Also should we be returning tombstoned posts from items get or similar? What happens when the most recent 50 posts have been tombstoned and only these are returned to the user?

imaginator commented 10 years ago

I was thinking of something more like this:

(see deleted post)

https://news.ycombinator.com/item?id=6728162

I believe this is how youtube and reddit handle deleted posts but still keep the thread there.

On 14 November 2013 15:03, Lloyd Watkin notifications@github.com wrote:

The thing is, we'd never show the child posts in the UI (or would we?) so why no tombstone them? Also should we be returning tombstoned posts from items get or similar? What happens when the most recent 50 posts have been tombstoned and only these are returned to the user?

— Reply to this email directly or view it on GitHubhttps://github.com/buddycloud/buddycloud-server-java/issues/63#issuecomment-28485872 .

Simon Tennant | buddycloud.com | +49 17 8545 0880 | office hours: goo.gl/tQgxP