buddycloud / buddycloud.com

buddycloud static site generation and gh_pages
http://buddycloud.com
Other
18 stars 18 forks source link

Page title question #20

Open imaginator opened 10 years ago

imaginator commented 10 years ago

I'm trying to have the following:

Buddycloud Architecture

Top menu title=Architecture

Title on page="Architecture"

But it ends up looking like this: screenshot 2014-02-22 15 44 40

Anyway to make this work?

guilhermesgb commented 10 years ago

Yeah, the same page attribute was being used everywhere (by the top menu, the page title and also as the content of the h1 header).

To achieve this I simply added a new attribute for the page, which is called 'fulltitle' for now. The content generator will check if that attribute exists and fill the H1 header with it if so, or with the 'title' attribute otherwise.

imaginator commented 10 years ago

Great job! Thanks!

On 22 February 2014 15:57, Guilherme Santos notifications@github.comwrote:

Yeah, the same page attribute was being used everywhere (by the top menu, the page title and also as the content of the h1 header).

To achieve this I simply added a new attribute for the page, which is called 'fulltitle' for now. The content generator will check if that attribute exists and fill the H1 header with it if so, or with the 'title' attribute otherwise.

— Reply to this email directly or view it on GitHubhttps://github.com/buddycloud/buddycloud.com/issues/20#issuecomment-35804458 .

Simon Tennant | buddycloud.com | +49 17 8545 0880 | office hours: goo.gl/tQgxP

imaginator commented 10 years ago

Cant seem to get this working.

<html>
<head>
<meta name="fulltitle" content="" />
<meta name="url" content="features" />
<meta name="save_as" content="features.html" />
<meta name="order" content="1" />
<meta name="top_menu_name" content="Features" />

But I can't seem to get rid of the features title in this image. Could you try and update features.html with the way this is supposed to work and then I'll copy it to the other pages that we need.

screenshot 2014-03-01 17 21 58

guilhermesgb commented 10 years ago

It should have workes the way you did. Hmm it seems that by setting the meta value to "" it is considering the variable fulltitle undefined and thus picking the value of the title variable. I'm going to come up with a fix for this. On Mar 1, 2014 1:23 PM, "Simon Tennant" notifications@github.com wrote:

Cant seem to get this working.

But I can't seem to get rid of the features title in this image. Could you try and update features.html with the way this is supposed to work and then I'll copy it to the other pages that we need. [image: screenshot 2014-03-01 17 21 58]https://f.cloud.github.com/assets/469572/2301835/bde02af8-a15d-11e3-9ef0-1a4b1e5c5445.png ## Reply to this email directly or view it on GitHubhttps://github.com/buddycloud/buddycloud.com/issues/20#issuecomment-36428870 .
guilhermesgb commented 10 years ago

@imaginator I've made an update addressing this. Is http://buddycloud.com/features looking the way it should now?

vitoravelino commented 10 years ago

Since I removed the black background on the selected menu option, I added the title again. I see no problem with it.